|
I really enjoy this screensaver, much thanks to all who have worked on it.
On the OS X client, I noticed some transition sheep repeating as if they were loop sheep. I determined that if a loop sheep with no possible successors is about to be displayed, then the transition just prior to the loop will repeat (until Maximum Repeats is reached) instead of the loop sheep. I believe the source of the problem is line 1193 of electricsheep.m (version 1.90 in the CVS repository):
1191 // No need to reload the movie if we're going to play the
1192 // same animation again
1193 if ([newAnim getID] != [_nextAnim getID] || currentAnim == nil)
1194 {
1195 [newAnim retain];
1196 [currentAnim release];
1197 currentAnim = _nextAnim;
1198 _nextAnim = newAnim;
1199 loadNewMovie = YES;
1200 nRepeats = 1;
Changing line 1193 to the following fixed the bug for me: 1193 if ([currentAnim getID] != [_nextAnim getID] || currentAnim == nil) Please consider this change in the next release of Electric Sheep, and keep up the great work.
|
Messages