Not quite like that ... 

Forum: flame
Re: Bug and fix for OS X client (Michael Hohimer)
Date: 2007, May 13
From: Tom Lane

I'm unsure whether currentAnim really can be nil at this point in the code, but if it were then your proposed test would crash trying to invoke getID on a nonexistent object. Test it the other way round instead: if (currentAnim == nil || [currentAnim getID] != [_nextAnim getID]) This is not to express any opinion on the overall merit of the change, just to point out that the nil-test is quite useless where it is ...

[ Next-in-Thread ]  [ Next Message ] 

[ Add Message ]  to: "Not quite like that ..."

[ Members ]  [ Subscribe ]  [ Admin Mode ] 
[ Show Frames ]  [ Help for HyperNews at www.draves.org 1.10 ] 

Messages Inline: [ 1 ]  [ All ]  Outline: [ 1 ]  [ 2 ]  [ All ] 

1. Untitled by Michael Hohimer, 2007, May 13

[ Add Message ]  to: "Not quite like that ..."

[ Members ]  [ Subscribe ]  [ Admin Mode ] 
[ Show Frames ]  [ Help for HyperNews at www.draves.org 1.10 ] 

Long live the new flesh!